paleolimbot commented on issue #34887: URL: https://github.com/apache/arrow/issues/34887#issuecomment-1497451144
I haven't been following the refactor as closely as I should have; however, from a high level the "minimal" build is not all that important because it's fairly difficult for a user to actually get one (requires setting environment variables or linking to an existing minimal C++ build, which I have only ever managed to do accidentally). From that perspective, turning compute off on the "minimal" build is probably a good idea: anybody spending effort to get a smaller arrow R package build almost certainly does not need non-essential compute kernels. (At least one more opinion would be helpful here...I haven't been following issues for long enough to know what people are trying to do with minimal R builds). > Currently, in the PR, I am skipping all dplyr tests. I think that skipping dplyr tests if Acero is turned off is reasonable (or at least that attempting a finer-grained skipping strategy is unlikely to be worth our time). It sounds like the action item here might be to (1) make sure CMD check passes when ARROW_COMPUTE=OFF and (2) make ARROW_COMPUTE=OFF part of what you get with ARROW_R_MINIMAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
