tustvold commented on code in PR #5881:
URL: https://github.com/apache/arrow-datafusion/pull/5881#discussion_r1158511665
##########
datafusion/core/benches/sort.rs:
##########
@@ -41,167 +94,80 @@ use rand::rngs::StdRng;
use rand::{Rng, SeedableRng};
use tokio::runtime::Runtime;
-use lazy_static::lazy_static;
+use datafusion::physical_plan::coalesce_partitions::CoalescePartitionsExec;
/// Total number of streams to divide each input into
/// models 8 partition plan (should it be 16??)
-const NUM_STREAMS: u64 = 8;
+const NUM_STREAMS: usize = 8;
+
+/// The size of each batch within each stream
+const BATCH_SIZE: usize = 1024;
/// Total number of input rows to generate
const INPUT_SIZE: u64 = 100000;
-// cases:
-
-// * physical sort expr (X, Y Z, NULLS FIRST, ASC) (not parameterized)
-//
-// streams of distinct values
-// streams with 10% duplicated values (within each stream, and across streams)
-// These cases are intended to model important usecases in TPCH
-// parameters:
-//
-// Input schemas
-lazy_static! {
Review Comment:
Lazy static seemed overkill for what this was doing, I opted to keep things
simple
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
