mustafasrepo commented on code in PR #5874:
URL: https://github.com/apache/arrow-datafusion/pull/5874#discussion_r1158694724
##########
datafusion/common/src/utils.rs:
##########
@@ -162,6 +163,23 @@ where
Ok(low)
}
+/// This function finds the partition points according to `partition_columns`.
+/// If there are no sort columns, then the result will be a single element
+/// vector containing one partition range spanning all data.
+pub fn evaluate_partition_points(
Review Comment:
I looked up to the Informatica system definition for partition point (I
guess what you referred is [this
definition](https://docs.informatica.com/data-integration/powercenter/10-5/advanced-workflow-guide/understanding-pipeline-partitioning/partitioning-attributes/partition-points.html)).
These are different. If it is misleading, it is better to rename this
function. What do you think about renaming it with
`evaluate_partition_ranges`?.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
