alamb opened a new pull request, #5889: URL: https://github.com/apache/arrow-datafusion/pull/5889
# Which issue does this PR close? # Rationale for this change While reviewing https://github.com/apache/arrow-datafusion/pull/5881 I had to look up what exactly "new_with_partitioning" did and what all the arguments meant and found the whole thing quite obtuse. Let's make this clearer. # What changes are included in this PR? 1. Add doc comments better explaining what SortExec does and what `preserve_partitioning` does 1. Add `SortExec::new()` which is infallable (try_new always returned true) 2. Add `SortExec::with_preserve_partitioning` to set the preserve partitioning flag 3. Mark `SortExec::try_new()` and `SortExec::new_with_partitioning` as deprecated # Are these changes tested? Yes, by clippy and existing tests # Are there any user-facing changes? The old APIs are deprecated, but they will still work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
