kou commented on code in PR #34844:
URL: https://github.com/apache/arrow/pull/34844#discussion_r1159048205
##########
dev/tasks/homebrew-formulae/apache-arrow.rb:
##########
@@ -72,6 +72,7 @@ def install
# link against system libc++ instead of llvm provided libc++
ENV.remove "HOMEBREW_LIBRARY_PATHS", Formula["llvm"].opt_lib
args = %W[
+ -DARROW_ACERO=ON
Review Comment:
I see. Thanks.
For `dev/tasks/homebrew-formulae/apache-arrow.rb`, this is a file for
Homebrew's CI. (We should sync with
https://github.com/Homebrew/homebrew-core/blob/master/Formula/apache-arrow.rb
.) This is not only for R. In general, Homebrew enables all features as much as
possible. So I think that we don't need to assume that we may disable only
`ARROW_DATASET` in this file. (We should omit redundant `-DARROW_ACERO=ON`.)
For `dev/tasks/homebrew-formulae/autobrew/`, they are only for R. So I think
that your point is valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
