jackwener commented on PR #5831:
URL:
https://github.com/apache/arrow-datafusion/pull/5831#issuecomment-1499030395
> @jackwener One thing need to confirm with you is the `Error` behavior.
> Originally the optimizer rules might return an error, and the logical plan
optimizer will skip the failed rule by default and will
> not fail the SQL. But I think for Analyzer rules, if the rule return an
`Error`, I think the SQL should failure immediately.
> For the `type_coercion` rule, the rule itself is to ensure the
correctness, I think if there is error, the SQL should failure.
Agree with it, before this PR, I already fix some bug about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]