alamb commented on code in PR #5900:
URL: https://github.com/apache/arrow-datafusion/pull/5900#discussion_r1160136124
##########
datafusion/core/src/physical_plan/file_format/file_stream.rs:
##########
@@ -264,9 +264,9 @@ impl<F: FileOpener> FileStream<F> {
Ok(reader) => {
let partition_values = mem::take(partition_values);
- let next = self.start_next_file().transpose();
-
+ // include time needed to start opening in
`start_next_file`
Review Comment:
With this change, the FileStream now consistently includes the time for
`start_next_file` in `time_opening` -- both here and immediately above:
https://github.com/apache/arrow-datafusion/blob/5c0fe0d7ebe0b205ce10c2b07ee2230ff3df6cba/datafusion/core/src/physical_plan/file_format/file_stream.rs#L244-L246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
