rok commented on code in PR #34797:
URL: https://github.com/apache/arrow/pull/34797#discussion_r1160534276
##########
cpp/src/arrow/extension/fixed_shape_tensor.h:
##########
@@ -74,10 +98,17 @@ class ARROW_EXPORT FixedShapeTensorType : public
ExtensionType {
const std::vector<int64_t>& permutation = {},
const std::vector<std::string>& dim_names = {});
+ /// \brief Compute strides of FixedShapeTensorType
+ static Status ComputeStrides(const FixedWidthType& type,
Review Comment:
The reason it's like this now is because both `FixedShapeTensorType` and
`FixedShapeTensorArray` are using `ComputeStrides`, but `ComputeStrides` is a
`FixedShapeTensorType` method. I'll see if I can put it into another namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
