waitingkuo commented on code in PR #5914:
URL: https://github.com/apache/arrow-datafusion/pull/5914#discussion_r1160691915
##########
datafusion/sql/src/expr/arrow_cast.rs:
##########
@@ -580,8 +632,15 @@ mod test {
DataType::Timestamp(TimeUnit::Millisecond, None),
DataType::Timestamp(TimeUnit::Microsecond, None),
DataType::Timestamp(TimeUnit::Nanosecond, None),
- // TODO support timezones
- //DataType::Timestamp(TimeUnit::Nanosecond, Some("UTC".into())),
+ // we can't cover all possible timezones, here we only test utc
and +08:00
+ DataType::Timestamp(TimeUnit::Nanosecond, Some("+00:00".into())),
+ DataType::Timestamp(TimeUnit::Microsecond, Some("+00:00".into())),
+ DataType::Timestamp(TimeUnit::Millisecond, Some("+00:00".into())),
+ DataType::Timestamp(TimeUnit::Second, Some("+00:00".into())),
+ DataType::Timestamp(TimeUnit::Nanosecond, Some("+08:00".into())),
+ DataType::Timestamp(TimeUnit::Microsecond, Some("+08:00".into())),
+ DataType::Timestamp(TimeUnit::Millisecond, Some("+08:00".into())),
+ DataType::Timestamp(TimeUnit::Second, Some("+08:00".into())),
Review Comment:
thanks @alamb , more error handling and test cases added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
