viirya commented on PR #5675: URL: https://github.com/apache/arrow-datafusion/pull/5675#issuecomment-1500517561
> Does this new `PromotePrecision` expr only apply to Decimal type? > I remember in the SparkSQL there was a similar `PromotePrecision`, not sure whether it is for the same purpose. > And looks like in the latest Spark, it is removed or renamed. It is for Decimal type only. Yea, the idea is from Spark. It was removed in latest Spark as the precision promotion is moved to where the computation happens. I was not sure if moving it into decimal kernels is a good idea for DataFusion. Let me re-think about it and maybe refactor this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
