wesm commented on a change in pull request #8770:
URL: https://github.com/apache/arrow/pull/8770#discussion_r532736857
##########
File path: cpp/src/arrow/compute/kernels/vector_selection.cc
##########
@@ -589,37 +590,9 @@ class PrimitiveFilterImpl {
void ExecNonNull() {
// Fast filter when values and filter are not null
- // Bit counters used for both null_selection behaviors
- BitBlockCounter filter_counter(filter_data_, filter_offset_,
values_length_);
-
- int64_t in_position = 0;
- BitBlockCount current_block = filter_counter.NextWord();
- while (in_position < values_length_) {
- if (current_block.AllSet()) {
- int64_t run_length = 0;
- // If we've found a all-true block, then we scan forward until we find
- // a block that has some false values (or we reach the end
- while (current_block.length > 0 && current_block.AllSet()) {
- run_length += current_block.length;
- current_block = filter_counter.NextWord();
- }
- WriteValueSegment(in_position, run_length);
- in_position += run_length;
- } else if (current_block.NoneSet()) {
- // Nothing selected
- in_position += current_block.length;
- current_block = filter_counter.NextWord();
- } else {
- // Some values selected
- for (int64_t i = 0; i < current_block.length; ++i) {
- if (BitUtil::GetBit(filter_data_, filter_offset_ + in_position)) {
- WriteValue(in_position);
- }
- ++in_position;
- }
- current_block = filter_counter.NextWord();
- }
- }
+ ::arrow::internal::VisitSetBitRunsVoid(
+ filter_data_, filter_offset_, values_length_,
+ [&](int64_t position, int64_t length) { WriteValueSegment(position,
length); });
Review comment:
Very nice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
