tustvold commented on code in PR #4040:
URL: https://github.com/apache/arrow-rs/pull/4040#discussion_r1161324324
##########
object_store/src/http/mod.rs:
##########
@@ -271,8 +283,16 @@ mod tests {
use super::*;
- #[tokio::test]
- async fn http_test() {
+ /// Deletes any directories left behind from previous tests
+ async fn cleanup_directories(integration: &HttpStore) {
Review Comment:
This is necessary because we now run the test twice, and the directories
left behind cause tests of list_with_delimiter to fail.
I have confirmed that this behaviour of returning common prefixes for empty
directories is consistent with LocalFileSystem. The reason we don't run into
this with LocalFileSystem is that it creates a new temp directory for each test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
