lidavidm commented on code in PR #577:
URL: https://github.com/apache/arrow-adbc/pull/577#discussion_r1161364187
##########
c/driver/postgresql/connection.cc:
##########
@@ -47,7 +48,97 @@ AdbcStatusCode PostgresConnection::GetTableSchema(const
char* catalog,
const char* table_name,
struct ArrowSchema* schema,
struct AdbcError* error) {
- return ADBC_STATUS_NOT_IMPLEMENTED;
+ // TODO: sqlite uses a StringBuilder class that seems roughly equivalent
Review Comment:
See #92 and #314. I sort of wanted to avoid having a single mega cmake
project (like Arrow) but it does make it a little harder to share common
snippets.
It may be time to pull out a `c/driver/utils` that can (for now) be
referenced in multiple drivers (the same way `c/vendor/nanoarrow` is)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
