kou commented on PR #34919: URL: https://github.com/apache/arrow/pull/34919#issuecomment-1501420706
@anthonylouisbsb @projjal @praveenbingo You changed our vendored double-conversion in #9816. Is the change still needed? Some Gandiva tests failed by upgrading vendored double-conversion (the change is revered): https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/46724699#L2520 ```text [ RUN ] TestGdvFnStubs.TestCastVARCHARFromFloat C:/projects/arrow/cpp/src/gandiva/gdv_function_stubs_test.cc(400): error: Expected equality of these values: std::string(out_str, out_len) Which is: "1E-5" "1.0E-5" [ FAILED ] TestGdvFnStubs.TestCastVARCHARFromFloat (0 ms) [ RUN ] TestGdvFnStubs.TestCastVARCHARFromDouble C:/projects/arrow/cpp/src/gandiva/gdv_function_stubs_test.cc(435): error: Expected equality of these values: std::string(out_str, out_len) Which is: "1E-5" "1.0E-5" [ FAILED ] TestGdvFnStubs.TestCastVARCHARFromDouble (0 ms) ``` If you really need the change, could you improve double-conversion in upstream instead of changing vendored double-conversion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
