icexelloss commented on code in PR #34904:
URL: https://github.com/apache/arrow/pull/34904#discussion_r1161705566
##########
cpp/src/arrow/acero/aggregate_node.cc:
##########
@@ -373,14 +371,50 @@ class ScalarAggregateNode : public ExecNode, public
TracedNode {
ARROW_ASSIGN_OR_RAISE(auto out_type,
kernels[i]->signature->out_type().Resolve(
&kernel_ctx,
kernel_intypes[i]));
- fields[base + i] =
- field(aggregate_options.aggregates[i].name, out_type.GetSharedPtr());
+ fields[base + i] = field(aggregates[i].name, out_type.GetSharedPtr());
+ }
+
+ return AggregateNodeArgs<ScalarAggregateKernel>{schema(std::move(fields)),
+ {},
Review Comment:
Can you add a comment to the empty list args here? e.g.
/*param*/{}
##########
cpp/src/arrow/acero/aggregate_node.cc:
##########
@@ -373,14 +371,50 @@ class ScalarAggregateNode : public ExecNode, public
TracedNode {
ARROW_ASSIGN_OR_RAISE(auto out_type,
kernels[i]->signature->out_type().Resolve(
&kernel_ctx,
kernel_intypes[i]));
- fields[base + i] =
- field(aggregate_options.aggregates[i].name, out_type.GetSharedPtr());
+ fields[base + i] = field(aggregates[i].name, out_type.GetSharedPtr());
+ }
+
+ return AggregateNodeArgs<ScalarAggregateKernel>{schema(std::move(fields)),
+ {},
Review Comment:
Can you add a comment to the empty list args here? e.g.
```
/*param*/{}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
