alamb opened a new pull request, #5946: URL: https://github.com/apache/arrow-datafusion/pull/5946
# Which issue does this PR close? Related to https://github.com/apache/arrow-datafusion/issues/5717 # Rationale for this change During the review of https://github.com/apache/arrow-datafusion/pull/5775 I noticed there was unsafe code in `datafusion-proto` for seemingly unecessary reasons. See https://github.com/apache/arrow-datafusion/pull/5775#discussion_r1161492804 # What changes are included in this PR? 1. Remove `unsafe` code. 2. Add boundary tests to ensure substrait roundtrip casting works # Are these changes tested? Yes new tests are added # Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
