kou commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-736219706


   Could you add required GoogleTest version check?
   
   ```diff
   diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake 
b/cpp/cmake_modules/ThirdpartyToolchain.cmake
   index bdf15e4bc..60bdf13ad 100644
   --- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
   +++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
   @@ -1682,7 +1682,7 @@ set(_GTEST_LIBRARY_DIR "${GTEST_PREFIX}/lib")
    endmacro()
    
    if(ARROW_TESTING)
   -  resolve_dependency(GTest)
   +  resolve_dependency(GTest REQUIRED_VERSION 1.10.0)
    
      if(NOT GTEST_VENDORED)
        # TODO(wesm): This logic does not work correctly with the MSVC static 
libraries
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to