thisisnic commented on code in PR #34685:
URL: https://github.com/apache/arrow/pull/34685#discussion_r1162488308
##########
r/tests/testthat/test-dplyr-query.R:
##########
@@ -550,22 +505,27 @@ test_that("show_exec_plan(), show_query() and explain()",
{
show_exec_plan(),
regexp = paste0(
"ExecPlan with .* nodes:.*", # boiler plate for ExecPlan
- "OrderBySinkNode.*wt.*DESC.*", # arrange goes via the OrderBy sink node
+ "OrderBy.*wt.*DESC.*", # arrange goes via the OrderBy node
"FilterNode.*", # filter node
"TableSourceNode.*" # entry point
)
)
# printing the ExecPlan for a nested query would currently force the
# evaluation of the inner one(s), which we want to avoid => no output
- expect_warning(
+ expect_output(
mtcars %>%
arrow_table() %>%
filter(mpg > 20) %>%
- arrange(desc(wt)) %>%
head(3) %>%
show_exec_plan(),
- "The `ExecPlan` cannot be printed for a nested query."
+ paste0(
+ "ExecPlan with 4 nodes:.*",
+ "3:SinkNode.*",
+ "2:FetchNode.offset=0 count=3.*",
+ "1:FilterNode.filter=.mpg > 20.*",
+ "0:TableSourceNode.*"
+ )
Review Comment:
Awesome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
