mingmwang commented on code in PR #5837:
URL: https://github.com/apache/arrow-datafusion/pull/5837#discussion_r1162474934
##########
datafusion/core/src/physical_plan/aggregates/mod.rs:
##########
@@ -147,6 +149,24 @@ impl PhysicalGroupBy {
}
}
+impl PartialEq for PhysicalGroupBy {
+ fn eq(&self, other: &PhysicalGroupBy) -> bool {
+ self.expr.len() == other.expr.len()
+ && self
+ .expr
+ .iter()
+ .zip(other.expr.iter())
+ .all(|((expr1, name1), (expr2, name2))| expr1.eq(expr2) &&
name1 == name2)
Review Comment:
It looks like if Struct contains any boxed Trait Object, we can not use the
`PartialEq` derive macros.
https://github.com/rust-lang/rust/issues/39128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
