lidavidm commented on code in PR #582:
URL: https://github.com/apache/arrow-adbc/pull/582#discussion_r1162672901
##########
c/cmake_modules/AdbcDefines.cmake:
##########
@@ -69,6 +69,15 @@ set_target_properties(nanoarrow
"${REPOSITORY_ROOT}/c/vendor/"
POSITION_INDEPENDENT_CODE ON)
+# Shared ADBC Driver libraries
+add_library(adbc_driver_shared STATIC EXCLUDE_FROM_ALL
Review Comment:
It's a bit confusing to name this 'driver_shared' while it's a static
library (usually in Arrow libraries that convention means this is a dynamic
library). Maybe `driver_common`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
