AlenkaF commented on PR #34883: URL: https://github.com/apache/arrow/pull/34883#issuecomment-1503207748
I suggest we then first use the 3rd option: "Return always the actual C-contiguous array and raise error if permutation is non-trivial" and as Joris mentioned, finetune it in a follow-up PR (after the work on `to/from_tensor` in C++ is finished). The check for `to_numpy_ndarray` was added with the last commit: https://github.com/apache/arrow/pull/34883/commits/1ebb8297773494813f5515215cb869eb0ea959f6 @rok do you agree with the current state of this PR? If yes we could merge it today and get it into 12.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
