alamb commented on code in PR #5782:
URL: https://github.com/apache/arrow-datafusion/pull/5782#discussion_r1162896782
##########
datafusion/core/tests/sqllogictests/test_files/arrow_typeof.slt:
##########
@@ -176,10 +176,10 @@ drop table foo
statement ok
create table foo as select
- arrow_cast(100, 'Decimal128(3,2)') as col_d128
+ arrow_cast(100, 'Decimal128(5,2)') as col_d128
Review Comment:
cc @viirya
##########
datafusion/common/src/dfschema.rs:
##########
@@ -489,20 +497,16 @@ impl DFSchema {
impl From<DFSchema> for Schema {
/// Convert DFSchema into a Schema
fn from(df_schema: DFSchema) -> Self {
- Schema::new_with_metadata(
- df_schema.fields.into_iter().map(|f| f.field).collect(),
- df_schema.metadata,
- )
+ let fields: Fields = df_schema.fields.into_iter().map(|f|
f.field).collect();
Review Comment:
🤮 at least this should be cheaper at runtime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
