comphead commented on code in PR #5960:
URL: https://github.com/apache/arrow-datafusion/pull/5960#discussion_r1162980537
##########
datafusion/core/tests/sqllogictests/test_files/timestamps.slt:
##########
@@ -660,6 +660,12 @@ statement error DataFusion error: Error during planning:
Timestamp\(Nanosecond,
SELECT ts1 + ts2
FROM foo;
+# Timestamp - Timestamp
+query ?
Review Comment:
Please add negative test if older date - newer date
##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -239,8 +238,7 @@ pub fn temporal_add_sub_coercion(
if (is_date(lhs) || is_timestamp(lhs))
&& (is_date(rhs) || is_timestamp(rhs)) =>
{
- // TODO: support Minus
- None
+ temporal_coercion(lhs, rhs)
Review Comment:
if the comment about error still relevant?
for `temporal_coercion` if it does the actual substract?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
