tustvold commented on code in PR #4042:
URL: https://github.com/apache/arrow-rs/pull/4042#discussion_r1163064906
##########
arrow-schema/src/datatype.rs:
##########
@@ -498,6 +498,27 @@ impl DataType {
}
}
}
+
+ /// Check to see if `self` is a superset of `other`
+ ///
+ /// If DataType is a nested type, then it will check to see if the nested
type is a superset of the other nested type
+ /// else it will check to see if the DataType is equal to the other
DataType
+ pub fn contains(&self, other: &Field) -> bool {
Review Comment:
```suggestion
pub fn contains(&self, other: &DataType) -> bool {
```
I would expect this to take a `DataType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
