nealrichardson commented on a change in pull request #8813: URL: https://github.com/apache/arrow/pull/8813#discussion_r533657147
########## File path: r/vignettes/install.Rmd ########## @@ -284,7 +284,11 @@ so that we can attempt to improve the script. ## Known installation issues * On CentOS, if you are using a more modern `devtoolset`, you may need to set -the environment variables `CC=/usr/bin/gcc CXX=/usr/bin/g++`. +the environment variables `CC` and `CXX` (e.g., in the R `Makeconf` file). +These may be set to system defaults (e.g., `CC=/usr/bin/gcc CXX=/usr/bin/g++`) +or they may be set to use the `gcc`/`g++` from the devtoolset. In the latter +case, you will have to make sure that the system arrow dependencies are not +used (i.e., make sure the system variable `ARROW_USE_PKG_CONFIG` is false). See discussion [here](https://issues.apache.org/jira/browse/ARROW-8586). Review comment: ```suggestion See discussions [here](https://issues.apache.org/jira/browse/ARROW-8586) and [here](https://issues.apache.org/jira/browse/ARROW-10780). ``` ########## File path: r/vignettes/install.Rmd ########## @@ -284,7 +284,11 @@ so that we can attempt to improve the script. ## Known installation issues * On CentOS, if you are using a more modern `devtoolset`, you may need to set -the environment variables `CC=/usr/bin/gcc CXX=/usr/bin/g++`. +the environment variables `CC` and `CXX` (e.g., in the R `Makeconf` file). +These may be set to system defaults (e.g., `CC=/usr/bin/gcc CXX=/usr/bin/g++`) +or they may be set to use the `gcc`/`g++` from the devtoolset. In the latter +case, you will have to make sure that the system arrow dependencies are not +used (i.e., make sure the system variable `ARROW_USE_PKG_CONFIG` is false). Review comment: ... "because the system packages are built with the system compilers"? Is that the reason? It's worth explaining IMO. Interestingly, for CentOS 6 we do build with devtoolset-8 (https://github.com/apache/arrow/blob/master/dev/tasks/linux-packages/apache-arrow/yum/centos-6/Dockerfile#L23), but we don't for CentOS 7 or higher. @kou does that make sense? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
