zeroshade commented on code in PR #35051:
URL: https://github.com/apache/arrow/pull/35051#discussion_r1164364544
##########
go/arrow/flight/flightsql/driver/config.go:
##########
@@ -30,14 +74,15 @@ type DriverConfig struct {
Timeout time.Duration
Params map[string]string
- TLSEnabled bool
- TLSConfig *tls.Config
+ TLSEnabled bool
+ TLSConfigName string
+ TLSConfig *tls.Config
}
func NewDriverConfigFromDSN(dsn string) (*DriverConfig, error) {
u, err := url.Parse(dsn)
if err != nil {
- return nil, err
+ return nil, fmt.Errorf("invalid URL: %w", err)
}
// Sanity checks on the given connection string
Review Comment:
I just want to maintain the consistency with the other existing
implementations (pyarrow.flight, arrow c++ flight, etc.) so I think we should
at minimum add the support for the ones above. there's nothing wrong with also
supporting the `flightsql://` scheme too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
