jorgecarleitao commented on pull request #8796: URL: https://github.com/apache/arrow/pull/8796#issuecomment-737336658
@alamb I agree with the simplest but no simpler rule. I also agree with your concerns about the benches being run on ad-hoc hardware. It makes it more difficult to reproduce and draw conclusions. @Dandandan , I do not think so, but you may have better ideas than me: The way I currently see it, `ArrayData` is 'array-type'-independent. If we make buffers generic over T, we need to find a way to write `ArrayData`. We could make it logic-dependent, but then we lose the flexibility of a non-generic `ArrayData`, particularly on composite types such as `ListArray`, which have childs of generic types. One way out would be to make `ArrayData`'s dynamically typed, so that it can hold arbitrary childs, but I think that at some point we will need to downcast them as we will need to extract which type T their buffers contain. This is just my analysis and in no way a definitive answer about this, though ^_^ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
