benibus commented on code in PR #35002:
URL: https://github.com/apache/arrow/pull/35002#discussion_r1164516798
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -402,6 +402,7 @@ list(APPEND
compute/registry.cc
compute/kernels/codegen_internal.cc
compute/kernels/row_encoder.cc
+ compute/kernels/ree_util_internal.cc
Review Comment:
Does this need to be included in the default build or should it be
conditionally compiled when `ARROW_COMPUTE=ON` alongside
`vector_run_end_encode.cc` in [this
block](https://github.com/apache/arrow/blob/3a3d1ccde4023cb769eb8a2c10531ee6dce666dc/cpp/src/arrow/CMakeLists.txt#L428)?
If you expect the utils will be used outside of the REE-kernels then it's
probably fine where it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
