NGA-TRAN opened a new pull request, #5982: URL: https://github.com/apache/arrow-datafusion/pull/5982
# Which issue does this PR close? This is fir first part of https://github.com/apache/arrow-datafusion/issues/5689 to support month & year interval for constant input. The month interval for array input was converted into `ScalarValue::IntervalDayTime` (days) somewhere. My next PR is to find that place and convert month interval into `ScalarValue::IntervalMonthDayNano` instead. I think if I do that, they will automatically work with this code <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #. # Rationale for this change In IOx, we see users use `data_bin` with month interval to group data by month for their monthly report. We think it is a very useful feature to support. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? Since each month does not include the same number of nanoseconds and for date_bin, it also depends on the `origin` input. This PR mainly add a function to handle month interval for date bin and some related refactoring work <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are these changes tested? Yes <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? Yes, date_bin with month and year interval is now working on constant input <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
