korowa commented on PR #5937: URL: https://github.com/apache/arrow-datafusion/pull/5937#issuecomment-1506461751
> Currently, testing of memory limit SHJ is blocked as I need to implement a PartitionMode selection and enable with_repartition_joins to remove RepartitionExec's from the planner based on the configuration. Won't it help to enable pipeline related physical optimizer rules and use single target partition in `memory_limit.rs` over two unbounded sources to plan SHJ? > I can build ExecutionPlan without a query, which is different than other tests. And if it's blocked at this moment, I guess this is fine option -- to add operator-level test for overallocation case (like other tests in `symmetric_hash_join.rs` maybe). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
