roeap commented on code in PR #4082:
URL: https://github.com/apache/arrow-rs/pull/4082#discussion_r1165965431
##########
object_store/src/aws/mod.rs:
##########
@@ -758,12 +758,16 @@ impl AmazonS3Builder {
fn parse_url(&mut self, url: &str) -> Result<()> {
let parsed = Url::parse(url).context(UnableToParseUrlSnafu { url })?;
let host = parsed.host_str().context(UrlNotRecognisedSnafu { url })?;
-
match parsed.scheme() {
"s3" | "s3a" => self.bucket_name = Some(host.to_string()),
"https" => match host.splitn(4, '.').collect_tuple() {
- Some(("s3", bucket, "amazonaws", "com")) => {
- self.bucket_name = Some(bucket.to_string());
+ Some(("s3", region, "amazonaws", "com")) => {
+ self.region = Some(region.to_string());
+ if let Some(bucket) =
+ parsed.path_segments().and_then(|mut path| path.next())
Review Comment:
Of course and done - sorry for getting sloppy :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
