tustvold commented on code in PR #4084:
URL: https://github.com/apache/arrow-rs/pull/4084#discussion_r1166003059
##########
arrow-ord/src/comparison.rs:
##########
@@ -6165,6 +6171,128 @@ mod tests {
assert_eq!(e, r);
}
+ #[test]
+ fn test_decimal256_scalar_i128() {
+ let a = Decimal256Array::from_iter_values(
+ [1, 2, 3, 4, 5].into_iter().map(i256::from_i128),
+ );
+ let b = i256::from_i128(3);
+ // array eq scalar
+ let e = BooleanArray::from(
+ vec![Some(false), Some(false), Some(true), Some(false),
Some(false)],
+ );
+ let r = eq_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = eq_dyn_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+
+ // array neq scalar
+ let e = BooleanArray::from(
+ vec![Some(true), Some(true), Some(false), Some(true), Some(true)],
+ );
+ let r = neq_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = neq_dyn_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+
+ // array lt scalar
+ let e = BooleanArray::from(
+ vec![Some(true), Some(true), Some(false), Some(false),
Some(false)],
+ );
+ let r = lt_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = lt_dyn_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+
+ // array lt_eq scalar
+ let e = BooleanArray::from(
+ vec![Some(true), Some(true), Some(true), Some(false), Some(false)],
+ );
+ let r = lt_eq_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = lt_eq_dyn_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+
+ // array gt scalar
+ let e = BooleanArray::from(
+ vec![Some(false), Some(false), Some(false), Some(true),
Some(true)],
+ );
+ let r = gt_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = gt_dyn_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+
+ // array gt_eq scalar
+ let e = BooleanArray::from(
+ vec![Some(false), Some(false), Some(true), Some(true), Some(true)],
+ );
+ let r = gt_eq_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = gt_eq_dyn_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ }
+
+ #[test]
+ fn test_decimal256_scalar_i256() {
+ let a = Decimal256Array::from_iter_values(
Review Comment:
```suggestion
// TODO: Support i256 scalars (#2837)
let a = Decimal256Array::from_iter_values(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
