lidavidm commented on code in PR #34817:
URL: https://github.com/apache/arrow/pull/34817#discussion_r1166419312
##########
cpp/src/arrow/flight/sql/server.cc:
##########
@@ -423,6 +494,91 @@ arrow::Result<Result>
PackActionResult(ActionCreatePreparedStatementResult resul
return PackActionResult(pb_result);
}
+arrow::Result<Result> PackActionResult(ActionSetSessionOptionsResult result) {
+ pb::sql::ActionSetSessionOptionsResult pb_result;
+ for (SetSessionOptionResult& res : result.results) {
+ switch (res) {
+ case SetSessionOptionResult::kUnspecified:
+ pb_result.add_results(
+
pb::sql::ActionSetSessionOptionsResult::SET_SESSION_OPTION_RESULT_UNSPECIFIED);
+ break;
+ case SetSessionOptionResult::kOk:
+ pb_result.add_results(
+
pb::sql::ActionSetSessionOptionsResult::SET_SESSION_OPTION_RESULT_OK);
+ break;
+ case SetSessionOptionResult::kInvalidResult:
+ pb_result.add_results(
+
pb::sql::ActionSetSessionOptionsResult::SET_SESSION_OPTION_RESULT_INVALID_VALUE);
+ break;
+ case SetSessionOptionResult::kError:
+ pb_result.add_results(
+
pb::sql::ActionSetSessionOptionsResult::SET_SESSION_OPTION_RESULT_ERROR);
+ break;
+ }
+ }
+ return PackActionResult(pb_result);
+}
+
+arrow::Result<Result> PackActionResult(ActionGetSessionOptionsResult result) {
+ pb::sql::ActionGetSessionOptionsResult pb_result;
+ for (const SessionOption& in_opt : result.session_options) {
+ pb::sql::SessionOption& opt = *pb_result.add_session_options();
Review Comment:
> Can do. Always believed the consistency of . vs -> was useful, but I will
update accordingly, thanks.
Yeah, it would be nice, but intra-codebase consistency is more valuable for
now. (The Google C++ guidelines have since updated to favor the reference in
all cases.) But changing this for us would mean hard compatibility breaks in
many, many APIs (and it would likely be possible to fix as we've been trying to
favor arrow::Result over out parameters _anyways_, but not sure if anyone is
driving that refactoring.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
