thinkharderdev commented on code in PR #658:
URL: https://github.com/apache/arrow-ballista/pull/658#discussion_r1166685343
##########
ballista/scheduler/src/state/task_manager.rs:
##########
@@ -738,17 +639,18 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> TaskManager<T, U>
}
/// Get the `ExecutionGraph` for the given job ID from cache
- pub(crate) async fn get_active_execution_graph(
+ pub(crate) fn get_active_execution_graph(
&self,
job_id: &str,
) -> Option<Arc<RwLock<ExecutionGraph>>> {
self.active_job_cache
.get(job_id)
- .map(|value| value.execution_graph.clone())
+ .as_deref()
+ .map(|cached| cached.execution_graph.clone())
}
/// Remove the `ExecutionGraph` for the given job ID from cache
- pub(crate) async fn remove_active_execution_graph(
Review Comment:
Sorry, by "global state" I mean state shared across multiple schedulers. The
`active_job_cache` is local to a single scheduler and and a purely in-memory
data structure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
