Crystrix commented on code in PR #35109:
URL: https://github.com/apache/arrow/pull/35109#discussion_r1166801034
##########
cpp/src/arrow/ArrowConfig.cmake.in:
##########
@@ -96,11 +96,20 @@ include("${CMAKE_CURRENT_LIST_DIR}/ArrowTargets.cmake")
if(TARGET Arrow::arrow_static AND NOT TARGET Arrow::arrow_bundled_dependencies)
add_library(Arrow::arrow_bundled_dependencies STATIC IMPORTED)
- get_target_property(arrow_static_location Arrow::arrow_static LOCATION)
- get_filename_component(arrow_lib_dir "${arrow_static_location}" DIRECTORY)
+ get_target_property(arrow_static_debug_location Arrow::arrow_static
+ IMPORTED_LOCATION_DEBUG)
+ get_filename_component(arrow_debug_lib_dir "${arrow_static_debug_location}"
DIRECTORY)
set_target_properties(Arrow::arrow_bundled_dependencies
PROPERTIES IMPORTED_LOCATION
-
"${arrow_lib_dir}/${CMAKE_STATIC_LIBRARY_PREFIX}arrow_bundled_dependencies${CMAKE_STATIC_LIBRARY_SUFFIX}"
+
"${arrow_debug_lib_dir}/${CMAKE_STATIC_LIBRARY_PREFIX}arrow_bundled_dependencies${CMAKE_STATIC_LIBRARY_SUFFIX}"
+ )
+ get_target_property(arrow_static_release_location Arrow::arrow_static
+ IMPORTED_LOCATION_RELEASE)
+ get_filename_component(arrow_release_lib_dir
"${arrow_static_release_location}"
+ DIRECTORY)
+ set_target_properties(Arrow::arrow_bundled_dependencies
+ PROPERTIES IMPORTED_LOCATION_RELEASE
+
"${arrow_release_lib_dir}/${CMAKE_STATIC_LIBRARY_PREFIX}arrow_bundled_dependencies${CMAKE_STATIC_LIBRARY_SUFFIX}"
Review Comment:
Yes, I've tested it both on Mac and CentOS with vcpkg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
