lidavidm commented on code in PR #35139:
URL: https://github.com/apache/arrow/pull/35139#discussion_r1167472479
##########
java/flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/accessor/impl/text/ArrowFlightJdbcVarCharVectorAccessorTest.java:
##########
@@ -510,14 +510,23 @@ public void
testShouldGetDateReturnValidDateWithCalendar() throws Exception {
Text value = new Text("2021-07-02");
when(getter.get(0)).thenReturn(value.copyBytes());
- Calendar calendar =
Calendar.getInstance(TimeZone.getTimeZone("America/Sao_Paulo"));
- Date result = accessor.getDate(calendar);
+ {
+ Calendar calendar =
Calendar.getInstance(TimeZone.getTimeZone("America/Sao_Paulo"));
+ Date result = accessor.getDate(calendar);
+ calendar.setTime(result);
- calendar = Calendar.getInstance(TimeZone.getTimeZone("Etc/UTC"));
- calendar.setTime(result);
+ collector.checkThat(dateTimeFormat.format(calendar.getTime()),
+ equalTo("2021-07-01T21:00:00.000Z"));
Review Comment:
> If timezone is not set, it assumes UTC and converts from that to target
timezone.
This seems a bit off though, since we don't _know_ the timezone in that case
specifically. (Not that the current behavior seems any better!) It seems like
the right behavior here would be to either treat this as an error, or behave
like Derby and treat the user-supplied calendar to mean, "assume the timestamp
is a timestamp as viewed in this time zone".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
