tustvold commented on code in PR #4065:
URL: https://github.com/apache/arrow-rs/pull/4065#discussion_r1167482698
##########
arrow-buffer/src/buffer/offset.rs:
##########
@@ -29,10 +29,13 @@ impl<O: ArrowNativeType> OffsetBuffer<O> {
/// # Panics
///
/// Panics if `buffer` is not a non-empty buffer containing
- /// monotonically increasing values greater than zero
+ /// monotonically increasing values greater than or equal to zero
pub fn new(buffer: ScalarBuffer<O>) -> Self {
assert!(!buffer.is_empty(), "offsets cannot be empty");
- assert!(buffer[0] > O::usize_as(0), "offsets must be greater than 0");
+ assert!(
Review Comment:
Yes
https://github.com/apache/arrow-rs/pull/4065/files#diff-6e2926e22029402309ee910c3a79ce67f5bae87f1b6aa27a57a9541a074d319aL103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
