icexelloss commented on PR #34392: URL: https://github.com/apache/arrow/pull/34392#issuecomment-1511557077
A quick look and a couple of questions: > The initial current time of 0, which is set by the MemoStore constructor, is invalid; Why would the code later unable to detect that the current time is invalid? (I assume this is invalid because it hasn't got any input?) > I believe the race condition is due to the non-deterministic order of arrival of batches to the as-of-join node, This is surprising - why would this happen in serial execution? And what evidence makes you believe this is happening? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
