PragmaTwice commented on PR #34002: URL: https://github.com/apache/arrow/pull/34002#issuecomment-1512342621
It appears that there are only a few individuals in the Arrow community who have good knowledge of C++. To begin with, I am confident that my code is accurate. Comparable code can be found in the standard library, such as `std::optional<T>::value_or`. In future versions of C++ (23 or later), we may even use *deducing this* to apply universal forwarding on `*this` and prevent redundant code. Furthermore, I am uncertain why method functions within class scope necessitate an `inline` specifier. This is implicit in the C++ standard and does not require explicit declaration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
