viirya commented on code in PR #4081:
URL: https://github.com/apache/arrow-rs/pull/4081#discussion_r1170261696
##########
arrow-array/src/array/byte_array.rs:
##########
@@ -60,6 +60,85 @@ impl<T: ByteArrayType> GenericByteArray<T> {
/// Data type of the array.
pub const DATA_TYPE: DataType = T::DATA_TYPE;
+ /// Create a new [`GenericByteArray`] from the provided parts, panicking
on failure
+ ///
+ /// # Panics
+ ///
+ /// Panics if [`GenericByteArray::try_new`] returns an error
+ pub fn new(
+ offsets: OffsetBuffer<T::Offset>,
+ values: Buffer,
+ nulls: Option<NullBuffer>,
+ ) -> Self {
+ Self::try_new(offsets, values, nulls).unwrap()
+ }
+
+ /// Create a new [`GenericByteArray`] from the provided parts, returning
an error on failure
+ ///
+ /// # Errors
+ ///
+ /// * `offsets.len() - 1 != nulls.len()`
+ /// * Any consecutive pair of `offsets` does not denote a valid slice of
`values`
+ pub fn try_new(
+ offsets: OffsetBuffer<T::Offset>,
+ values: Buffer,
+ nulls: Option<NullBuffer>,
+ ) -> Result<Self, ArrowError> {
+ let len = offsets.len() - 1;
+ T::validate(&offsets, &values)?;
+
+ if let Some(n) = nulls.as_ref() {
+ if n.len() != len {
Review Comment:
Don't we need to also check the length of values buffer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
