yevgenypats commented on code in PR #35161:
URL: https://github.com/apache/arrow/pull/35161#discussion_r1170516104
##########
go/arrow/array/compare.go:
##########
@@ -630,6 +631,34 @@ func validityBitmapEqual(left, right arrow.Array) bool {
return true
}
+func stripNulls(s string) string {
+ return strings.ReplaceAll(s, "\x00", "")
+}
+
Review Comment:
Interesting, wasn't aware of the valid utf8 specification that can't contain
NULLs in the middle of the string. In that case there is no check in
`string.Append`
[method](https://github.com/cloudquery/arrow/blob/main/go/arrow/array/string.go#L321)
to make sure there are no nulls inside the string. Should we add this check or
string nulls inside the string? wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
