indigophox commented on code in PR #34817:
URL: https://github.com/apache/arrow/pull/34817#discussion_r1170521388
##########
format/FlightSql.proto:
##########
@@ -1842,6 +1842,94 @@ message ActionCancelQueryResult {
CancelResult result = 1;
}
+/*
+ * Request message for the "Close Session" action.
+ */
+message ActionCloseSessionRequest {
Review Comment:
The concern was simply minimizing how much more stuff we're jamming into the
Arrow package (and if it's not really necessary etc), however I think this is
both important enough (to clarify the flow described above so we're not giving
users/developers a puzzle to put together) and not more bulk added to the core
code (Middleware being an optional helper) so it's probably worth adding an
interface and impl to the package.
Do the coding guidelines being used discourage MI?—by default I'm looking at
implementing the core Middleware interface plus the session object getter via
another interface that the new server session middleware would also inherit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
