2010YOUY01 commented on code in PR #6037: URL: https://github.com/apache/arrow-datafusion/pull/6037#discussion_r1170534897
########## datafusion/core/tests/sqllogictests/test_files/math.slt: ########## @@ -87,3 +87,9 @@ query RRRRRRRR SELECT round(125.2345, -3), round(125.2345, -2), round(125.2345, -1), round(125.2345), round(125.2345, 0), round(125.2345, 1), round(125.2345, 2), round(125.2345, 3) ---- 0 100 130 125 125 125.2 125.23 125.235 + +# atan2 +query RRRR Review Comment: Sure, expression tests for null cases can also be found [here](https://github.com/apache/arrow-datafusion/pull/2942/files#diff-d6e2f75f82c6d7f14f1bb07bc89293c7ef4c92c4c02241044e14ad9ea8ae213dR508), returning `NULL` seems to be expected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
