kevingurney commented on code in PR #34563: URL: https://github.com/apache/arrow/pull/34563#discussion_r1170561896
########## matlab/CMakeLists.txt: ########## Review Comment: 1. We are now using `FetchContent` to integrate the `libmexclass` code into the CMake build system for the MATLAB interface (see [this pull request for adding `FetchContent` support to `mathworks/libmexclass`](https://github.com/mathworks/libmexclass/pull/55)). Thank you @assignUser for this helpful suggestion! 2. Regarding the high minimum CMake version - this is an excellent question! I did a quick search through the history of changes to the `CMakeLists.txt` and found [this comment](https://github.com/apache/arrow/pull/10305#discussion_r657176867) discussing the rationale for using version `3.20` as the minimum. It looks like the main reason was to avoid some bugs that were present in [`FindMatlab`](https://cmake.org/cmake/help/latest/module/FindMatlab.html) with older versions of CMake. That being said, we agree that this is a pretty high minimum, and it may make sense to reconsider this decision and do a thorough examination of whether older versions might be OK to use. Since it may take some time to get access to development environments with older versions of CMake, it may make sense to capture this as a separate issue, so that we don't block this pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
