kou commented on code in PR #570:
URL: https://github.com/apache/arrow-adbc/pull/570#discussion_r1170690027
##########
c/driver_manager/adbc_driver_manager_test.cc:
##########
@@ -86,6 +86,47 @@ TEST_F(DriverManager, DatabaseCustomInitFunc) {
ASSERT_THAT(AdbcDatabaseRelease(&database, &error), IsOkStatus(&error));
}
+TEST_F(DriverManager, UninitializedError) {
+ struct AdbcDatabase database;
+ struct AdbcError invalid_err;
+ std::memset(&database, 0, sizeof(database));
+
+ // Force junk into AdbcError going into calls to
+ // simulate API calls using uninitialized AdbcError structs
+ std::memset(&invalid_err, 0xff, sizeof(invalid_err));
+ ASSERT_THAT(AdbcDatabaseInit(&database, &invalid_err),
+ IsStatus(ADBC_STATUS_INVALID_STATE, &invalid_err));
Review Comment:
We need to call `invalid_err.release(&invalid_err)` after this.
##########
c/driver_manager/adbc_driver_manager_test.cc:
##########
@@ -86,6 +86,47 @@ TEST_F(DriverManager, DatabaseCustomInitFunc) {
ASSERT_THAT(AdbcDatabaseRelease(&database, &error), IsOkStatus(&error));
}
+TEST_F(DriverManager, UninitializedError) {
+ struct AdbcDatabase database;
+ struct AdbcError invalid_err;
+ std::memset(&database, 0, sizeof(database));
+
+ // Force junk into AdbcError going into calls to
+ // simulate API calls using uninitialized AdbcError structs
+ std::memset(&invalid_err, 0xff, sizeof(invalid_err));
+ ASSERT_THAT(AdbcDatabaseInit(&database, &invalid_err),
+ IsStatus(ADBC_STATUS_INVALID_STATE, &invalid_err));
+
+ std::memset(&invalid_err, 0xff, sizeof(invalid_err));
+ ASSERT_THAT(AdbcDatabaseNew(&database, &error), IsOkStatus(&invalid_err));
+ ASSERT_THAT(
+ AdbcDatabaseSetOption(&database, "driver", "adbc_driver_sqlite",
&invalid_err),
+ IsOkStatus(&invalid_err));
+
+ ASSERT_THAT(AdbcDatabaseInit(&database, &invalid_err),
IsOkStatus(&invalid_err));
+ std::memset(&invalid_err, 0xff, sizeof(invalid_err));
+ ASSERT_THAT(
+ AdbcDatabaseSetOption(&database, "notavalidkey", "notavalidvalue",
&invalid_err),
+ IsStatus(ADBC_STATUS_NOT_IMPLEMENTED, &invalid_err));
Review Comment:
Ditto.
##########
c/driver_manager/adbc_driver_manager_test.cc:
##########
@@ -86,6 +86,47 @@ TEST_F(DriverManager, DatabaseCustomInitFunc) {
ASSERT_THAT(AdbcDatabaseRelease(&database, &error), IsOkStatus(&error));
}
+TEST_F(DriverManager, UninitializedError) {
+ struct AdbcDatabase database;
+ struct AdbcError invalid_err;
+ std::memset(&database, 0, sizeof(database));
+
+ // Force junk into AdbcError going into calls to
+ // simulate API calls using uninitialized AdbcError structs
+ std::memset(&invalid_err, 0xff, sizeof(invalid_err));
+ ASSERT_THAT(AdbcDatabaseInit(&database, &invalid_err),
+ IsStatus(ADBC_STATUS_INVALID_STATE, &invalid_err));
+
+ std::memset(&invalid_err, 0xff, sizeof(invalid_err));
+ ASSERT_THAT(AdbcDatabaseNew(&database, &error), IsOkStatus(&invalid_err));
+ ASSERT_THAT(
+ AdbcDatabaseSetOption(&database, "driver", "adbc_driver_sqlite",
&invalid_err),
+ IsOkStatus(&invalid_err));
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
