wgtmac opened a new pull request, #35233:
URL: https://github.com/apache/arrow/pull/35233

   ### Rationale for this change
   
   https://github.com/apache/arrow/pull/14142 implemented the logic to skip 
parquet records and added a lot of test caese. However, there is a minor issue 
in the test function `RecordReaderPrimitiveTypeTest::CheckReadValues` where `!` 
is missing.
   
   ```c++
       if (descr_->schema_node()->is_required()) {
         std::vector<int16_t> read_defs(
             record_reader_->def_levels(),
             record_reader_->def_levels() + record_reader_->levels_position());
         ASSERT_TRUE(vector_equal(expected_defs, read_defs));
       }
   
   ```
   
   ### What changes are included in this PR?
   
   Add `!` to `if (descr_->schema_node()->is_required())` as mentioned above.
   
   ### Are these changes tested?
   
   This is a fix to the test case.
   
   ### Are there any user-facing changes?
   
   NO.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to