comphead commented on code in PR #6065:
URL: https://github.com/apache/arrow-datafusion/pull/6065#discussion_r1171842885
##########
datafusion/core/src/physical_plan/aggregates/row_hash.rs:
##########
@@ -772,22 +773,22 @@ fn slice_and_maybe_filter(
filter_opt: Option<&Arc<dyn Array>>,
offsets: &[usize],
) -> Result<Vec<ArrayRef>> {
- let sliced_arrays: Vec<ArrayRef> = aggr_array
- .iter()
- .map(|array| array.slice(offsets[0], offsets[1] - offsets[0]))
- .collect();
+ let null_array = Arc::new(NullArray::new(0)) as ArrayRef;
+ let mut sliced_arrays: Vec<ArrayRef> = vec![null_array; aggr_array.len()];
Review Comment:
Another optimization that we traverse input collection only once, instead of
2 times in original implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
