2010YOUY01 opened a new pull request, #6067: URL: https://github.com/apache/arrow-datafusion/pull/6067
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Issue https://github.com/apache/arrow-datafusion/issues/3678 Prev PR that disabled codecov: https://github.com/apache/arrow-datafusion/pull/3679 # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> `cargo tarpaulin` will consume lots of disk space, previously it failed due to this reason. I tried removing several large files on GitHub Action virtual machines, then It can run again. Problem: after that, two dataframe tests failed, they're disabled temporarily. https://github.com/apache/arrow-datafusion/blob/10b0eff7dfbe195a724285bc166b20240e8ebccb/datafusion/core/src/dataframe.rs#L1978 https://github.com/apache/arrow-datafusion/blob/10b0eff7dfbe195a724285bc166b20240e8ebccb/datafusion/core/src/dataframe.rs#L2070 These two test cases are added after last time codecov CI is disabled, I don't know why they might fail under `cargo tarpaulin` Failure messages: ``` failures: ---- dataframe::tests::partition_aware_union stdout ---- thread 'dataframe::tests::partition_aware_union' panicked at 'assertion failed: `(left == right)` left: `2`, right: `1`', datafusion/core/src/dataframe.rs:2008:9 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ---- dataframe::tests::verify_join_output_partitioning stdout ---- thread 'dataframe::tests::verify_join_output_partitioning' panicked at 'assertion failed: `(left == right)` left: `UnknownPartitioning(1)`, right: `Hash([Column { name: "c1", index: 0 }, Column { name: "c2", index: 1 }], 1)`', datafusion/core/src/dataframe.rs:2112:21 failures: dataframe::tests::partition_aware_union dataframe::tests::verify_join_output_partitioning test result: FAILED. 1475 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 139.30s Apr 19 21:59:34.770 INFO cargo_tarpaulin::process_handling::linux: Launching test Apr 19 21:59:34.776 INFO cargo_tarpaulin::process_handling: running /home/runner/work/arrow-datafusion/arrow-datafusion/target/debug/deps/simplification-ba4cc1d732bcee01 ``` Failing CI run : https://github.com/2010YOUY01/arrow-datafusion/actions/runs/4750006102 Can be reproduced with CI config in this commit https://github.com/apache/arrow-datafusion/commit/75c7fb77094d7e4ce907db343b77f268f075356f # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
