alamb commented on code in PR #6052: URL: https://github.com/apache/arrow-datafusion/pull/6052#discussion_r1172545893
########## datafusion/core/src/scheduler/task.rs: ########## @@ -279,6 +280,7 @@ impl RecordBatchStream for ExecutionResultStream { /// The shared state of all [`Task`] created from the same [`PipelinePlan`] #[derive(Debug)] +#[allow(dead_code)] Review Comment: What do you think about adding a function like ```rust pub fn version(&self) -> &str { ... } ``` Which would avoid the need for allow(dead_code) perhaps -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org