rtpsw commented on code in PR #35249:
URL: https://github.com/apache/arrow/pull/35249#discussion_r1173465886
##########
cpp/src/arrow/engine/substrait/extension_set.cc:
##########
@@ -944,6 +944,26 @@ ExtensionIdRegistry::SubstraitAggregateToArrow
DecodeBasicAggregate(
call.id().name, " to have at least one
argument");
}
case 1: {
+ std::shared_ptr<compute::FunctionOptions> options = nullptr;
+ if (arrow_function_name == "stddev" || arrow_function_name ==
"variance") {
+ auto maybe_dist = call.GetOption("distribution");
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
